Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native ARM builders for container builds #1099

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Use native ARM builders for container builds #1099

merged 12 commits into from
Nov 7, 2024

Conversation

blt
Copy link
Collaborator

@blt blt commented Nov 6, 2024

What does this PR do?

This commit replaces #1088 and attempts to build a lading multi-platform image by use of organization provided ARM native builders. Unsure if this'll work but I figure it's worth a shot.

This commit replaces #1088 and attempts to build a lading multi-platform
image by use of organization provided ARM native builders. Unsure if this'll
work but I figure it's worth a shot.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt requested a review from a team as a code owner November 6, 2024 23:33
.github/workflows/container.yml Outdated Show resolved Hide resolved
.github/workflows/container.yml Outdated Show resolved Hide resolved
.github/workflows/container.yml Outdated Show resolved Hide resolved
Signed-off-by: Brian L. Troutwine <[email protected]>
blt added 10 commits November 6, 2024 15:40
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt enabled auto-merge (squash) November 7, 2024 02:43
Copy link
Contributor

@scottopell scottopell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
Do we need any changes to the metadata tagging to ensure that the manifest gets tagged with the version number during release?

@blt blt merged commit 7caabaf into main Nov 7, 2024
17 checks passed
@blt blt deleted the blt/arm-native-build branch November 7, 2024 14:29
@blt
Copy link
Collaborator Author

blt commented Nov 7, 2024

nice! Do we need any changes to the metadata tagging to ensure that the manifest gets tagged with the version number during release?

I don't think so but let me reconfirm and make a PR if that's broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants